Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: only use local particles for output profiles #141

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

streeve
Copy link
Collaborator

@streeve streeve commented Oct 24, 2024

Closes #140

@streeve streeve requested a review from pabloseleson October 24, 2024 03:13
@streeve streeve self-assigned this Oct 24, 2024
@streeve
Copy link
Collaborator Author

streeve commented Oct 28, 2024

@pabloseleson should be a quick review

Copy link
Collaborator

@pabloseleson pabloseleson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thermal_deformation

I run the ThermalDeformation example with mpirun -N 8. Attached is the result.

It seems the problem was run actually with 2 processors only. The red and blue points in the plot correspond to outputs from the different processors. The example uses 100 cells in the x-direction and the output file contains 100 rows. So, it seems the fix works fine.

I haven't checked the fix with the heat transfer though.

@streeve
Copy link
Collaborator Author

streeve commented Oct 30, 2024

I run the ThermalDeformation example with mpirun -N 8. Attached is the result.

It seems the problem was run actually with 2 processors only. The red and blue points in the plot correspond to outputs from the different processors. The example uses 100 cells in the x-direction and the output file contains 100 rows. So, it seems the fix works fine.

No, it was run with a 2x2x2 decomposition so only 2 ranks owned the cells in x at the requested yz postion

@streeve streeve merged commit bd587d2 into ORNL:main Oct 30, 2024
14 checks passed
@streeve streeve deleted the fixup_profile_local branch October 30, 2024 18:31
@streeve streeve restored the fixup_profile_local branch November 20, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated output data with MPI
2 participants